-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organise CSS Z-index #2095
Organise CSS Z-index #2095
Conversation
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's good to me :) Much clearer now . thanks
Yes, that is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SajidAlamQB.
Related to: #2014
Description
We use z-index everywhere and just add random number that works. It has become cumbersome to debug or fix any styling as z-indexes being added on top of each other.
Development notes
Introduced specific z-index variables in
variables.scss
to replace hard-coded values throughout the codebase.Introduced
$base
,$above
, and$below
variables to create a flexible system for defining z-index values. This method provides a clear and scalable way to layer elements relative to each other, avoiding conflicts and magic numbers:$base
: 0;$above
: 1;$below
: -1;Checklist
RELEASE.md
file