Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organise CSS Z-Index #2014

Closed
Huongg opened this issue Aug 1, 2024 · 2 comments
Closed

Organise CSS Z-Index #2014

Huongg opened this issue Aug 1, 2024 · 2 comments
Assignees
Labels
Enhancement Issue: Feature Request Quick Win Low/Medium priorities but quick to do

Comments

@Huongg
Copy link
Contributor

Huongg commented Aug 1, 2024

Description

I feel like we use z-index everywhere and just add random number that works. It will eventually become very hard to debug or fix any styling as z-indexes being added on top of each other.

The goal is to managing z-index and avoiding magic numbers. It will make it easier for every team member to contribute and debug

Possible Implementation

My proposal is to go through all the z-indexes we have and group and give them meaningful names.
Perhaps something like this:

Simple version

$zindex-flowchart: 0;
$zindex-metadata: 1;
$zindex-tooltip: 2;

More advance if we want to go with

$base: 0;
$above: 1;
$below: -1;

$zindex-flowchart: $base;
$zindex-metadata: $above + $base;

@Huongg Huongg added this to Kedro-Viz Aug 1, 2024
@Huongg Huongg moved this to Inbox in Kedro-Viz Aug 1, 2024
@rashidakanchwala rashidakanchwala changed the title Oragnise CSS Z-Index Organise CSS Z-Index Sep 9, 2024
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Sep 9, 2024
@rashidakanchwala rashidakanchwala added Enhancement Quick Win Low/Medium priorities but quick to do labels Sep 9, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Sep 16, 2024
@SajidAlamQB SajidAlamQB mentioned this issue Sep 16, 2024
5 tasks
@rashidakanchwala
Copy link
Contributor

I like the simpler version. It's easier to understand plus in future when you make more components; it's easier to understand how to place them.

@SajidAlamQB
Copy link
Contributor

Completed in: #2095

@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issue: Feature Request Quick Win Low/Medium priorities but quick to do
Projects
Status: Done
Development

No branches or pull requests

3 participants