-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the Expand all modular pipelines
toggle from the settings panel
#1858
Move the Expand all modular pipelines
toggle from the settings panel
#1858
Conversation
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB Please remove "General" label from setting modal as new Figma design. |
@SajidAlamQB On collapse/expand icon click, Please update URL query params |
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB In settings-modal.js as we are not updating URL you could remove code related to it.
|
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏼
Signed-off-by: Sajid Alam <[email protected]>
Hey Sajid! Thanks for this work! I've done some design QA with this link - https://6620ef0fc18fff36ef74b586--kedro-viz-expand-all.netlify.app/?types=nodes,datasets&expandAllPipelines=false. Please see my comments below: I can see the url updates from false to true when the pipeline is expanded or collapsed, nice!
Let me know if anything is unclear :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job @SajidAlamQB 😄 I've tested it locally and the expand/collapse button works as expected. The code also looks good to me, Just one small comment from me but no blocker.
src/components/flowchart-primary-toolbar/flowchart-primary-toolbar.test.js
Show resolved
Hide resolved
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Hey @stephkaiser I've made all the changes except the one quoted above, setting it to medium font with FFFFFF 85% had no visible change so I've kept it as is. |
src/components/experiment-tracking/run-details-modal/run-details-modal.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM. thanks Sajid!
Description
Related to: #1752
Research highlighted the need to make
Expand all modular pipelines
toggle more discoverable to users. It is currently in the settings panel which most users do not use often, and will be moved to the task bar in this PR.Development notes
Removed from settings menu:
Expand modular pipelines:
Checklist
RELEASE.md
file