Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the 'Expand all modular pipelines' toggle from the settings panel. #1752

Closed
NeroOkwa opened this issue Feb 14, 2024 · 2 comments · Fixed by #1858
Closed

Move the 'Expand all modular pipelines' toggle from the settings panel. #1752

NeroOkwa opened this issue Feb 14, 2024 · 2 comments · Fixed by #1858
Assignees
Labels
Design: Visual Design Issue: Feature Request Javascript Pull requests that update Javascript code Quick Win Low/Medium priorities but quick to do

Comments

@NeroOkwa
Copy link
Contributor

NeroOkwa commented Feb 14, 2024

Description

The #1750 research highlight the need to make this toggle more discoverable to users. It is currently in the settings panel which most users do not use regularly, and can be moved to the task bar.

image

Context

This would benefit users especially those with large complex graphs to easily expand/compress their modular pipelines. It would also contribute to solving for #1726.

Possible Implementation

This toggle can be moved to the task bar, besides the 'Filters' section.
image

@rashidakanchwala rashidakanchwala moved this to Inbox in Kedro-Viz Mar 11, 2024
@rashidakanchwala rashidakanchwala added Design: Visual Design Quick Win Low/Medium priorities but quick to do labels Mar 11, 2024
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Mar 11, 2024
@rashidakanchwala rashidakanchwala added the Javascript Pull requests that update Javascript code label Mar 18, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Mar 18, 2024
@stephkaiser stephkaiser moved this from Todo to In Progress in Kedro-Viz Mar 21, 2024
@stephkaiser
Copy link

stephkaiser commented Mar 21, 2024

I think it makes sense to pull this out of the settings modal since this is an action that users would like to use frequently as a toggle, therefore moving it to the utility bar where controls for adjusting the pipeline flowchart view currently are makes sense to me. I don't think this should be at the bottom though next to the zoom controls as these are controls for the canvas, whereas the controls above are specifically for adjusting the pipeline flowchart view itself (showing/hiding node labels, showing/hiding layers, and exporting the visualisation)

Designs for the updated utility bar can be found below:

Expand pipeline button - https://www.figma.com/file/qk6phA6mnULZjYbGQvqHks/Kedro-Master-2023?type=design&node-id=515-40537&mode=design&t=FHII664dUTSKRvES-4
Collapse pipeline button - https://www.figma.com/file/qk6phA6mnULZjYbGQvqHks/Kedro-Master-2023?type=design&node-id=515-40656&mode=design&t=FHII664dUTSKRvES-4

Updated settings modal (showing the default configuration for the toggles) -
Dark mode - https://www.figma.com/file/qk6phA6mnULZjYbGQvqHks/Kedro-Master-2023?type=design&node-id=515-42389&mode=design&t=FHII664dUTSKRvES-4
Light mode - https://www.figma.com/file/qk6phA6mnULZjYbGQvqHks/Kedro-Master-2023?type=design&node-id=515-44322&mode=design&t=FHII664dUTSKRvES-4

Let me know if you have any comments or thoughts!

@SajidAlamQB SajidAlamQB moved this from In Progress to In Review in Kedro-Viz Apr 17, 2024
@SajidAlamQB SajidAlamQB linked a pull request Apr 17, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Apr 22, 2024
@SajidAlamQB SajidAlamQB reopened this Apr 24, 2024
@SajidAlamQB
Copy link
Contributor

Following the PR, #1858, the implementation has been completed but there are still a few design changes @stephkaiser has noticed that still need to be addressed, so I've re-opened this issue to address these.

@SajidAlamQB SajidAlamQB moved this from Done to In Progress in Kedro-Viz Apr 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kedro-Viz Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design: Visual Design Issue: Feature Request Javascript Pull requests that update Javascript code Quick Win Low/Medium priorities but quick to do
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants