Implement fix for failing test for loading CSVDataSet from S3 bucket #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmholzer
changed the title
Signed-off-by: Jannic Holzer <[email protected]>
jmholzer
force-pushed
the
fix-failing-test-for-loading-CSVDataSet-from-S3-bucket
branch
from
8c1d1c0
to
b2b52b8
Compare
Signed-off-by: Jannic Holzer <[email protected]>
noklam
approved these changes
Nov 8, 2022
jmholzer
deleted the
fix-failing-test-for-loading-CSVDataSet-from-S3-bucket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jannic Holzer [email protected]
Description
Resolves #67
Development notes
Discovered that the source of the bug is another bug in moto (tested with moto==4.0.8, moto==3.0.4). Changing order of tests, so that TestCSVDataSetS3::test_load_and_confirm runs before TestCSVDataSet::test_protocol_usage avoids encountering the bug.
Checklist
RELEASE.mdfile