Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test for loading CSVDataSet from S3 bucket #67

Closed
jmholzer opened this issue Oct 31, 2022 · 0 comments · Fixed by #68
Closed

Fix failing test for loading CSVDataSet from S3 bucket #67

jmholzer opened this issue Oct 31, 2022 · 0 comments · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@jmholzer
Copy link
Contributor

Description

The test for kedro-datasets in the file tests/pandas/test_csv_dataset.py::TestCSVDataSetS3::test_load_and_confirm currently fails for Python 3.10. It only fails if called when all the tests in tests/pandas/test_csv_dataset.py are run. If it is called in isolation, the test will pass.

If the class TestCSVDataSetS3 is moved to the top of the file, so that it is executed (in order) before the remaining tests in the file, the test case will pass. Since this test does not share resources with any other test in the file and also passes when called in isolation, the time taken between fixture definition and running the test may play a role in causing this error.

Context

This bug currently blocks all development work on kedro-datasets.

Steps to Reproduce

  1. Checkout the main branch.
  2. Navigate to the kedro-datasets directory.
  3. Run pytest --no-cov tests/pandas/test_csv_dataset.py

All tests in this file pass apart from TestCSVDataSetS3::test_load_and_confirm.

The following error is produced:

E           kedro.io.core.DataSetError: Failed while loading data from data set CSVDataSet(filepath=test_bucket/test.csv, load_args={}, protocol=s3, save_args={'index': False}).
E           Forbidden

Your Environment

Include as many relevant details about the environment in which you experienced the bug:

  • Kedro version used (pip show kedro or kedro -V): 0.18.3
@jmholzer jmholzer added the bug Something isn't working label Oct 31, 2022
@yetudada yetudada moved this to In Progress in Kedro Framework Nov 2, 2022
@jmholzer jmholzer moved this from In Progress to In Review in Kedro Framework Nov 3, 2022
Repository owner moved this from In Review to Done in Kedro Framework Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant