-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure consistent JSON log format for automaxprocs #6335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great!
Could you please define this in a single place and just reference in each component? The best place is probably a new file in https://github.com/kedacore/keda/tree/main/pkg/util
fixed :) |
/run-e2e internal |
@omerap12 could you please also update Changelog? https://github.com/kedacore/keda/blob/main/CHANGELOG.md#improvements-1 |
Done |
Signed-off-by: Omer Aplatony <[email protected]>
/run-e2e internal |
Passed. can we merge it? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you move the changelog entry to the unreleased section? after the release it was moved to v2.16 and should be unreleased yet
Signed-off-by: Omer Aplatony <[email protected]>
hope I did it right this time lol |
/skip-e2e |
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: michael pechner <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
* fix: CVE-2024-45337 (#6422) Signed-off-by: Jorge Turrado <[email protected]> * :fix: ensure consistent JSON log format for automaxprocs (#6335) * fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Upgrade to the latest new-relic-go v2 client (#6325) Signed-off-by: Jorge Turrado <[email protected]> * refactor: replace experimental `maps` and `slices` with stdlib (#6372) Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA (#6368) Signed-off-by: Jorge Turrado <[email protected]> * fix: scaledjobs stuck as not ready (#6329) since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in #5916 Signed-off-by: Mårten Svantesson <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: Paused ScaledObject count is reported correctly after operator restart (#6322) Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * Bump go and deps (#6434) * Bump go and deps Signed-off-by: Jorge Turrado <[email protected]> * bump golang.org/x/net Signed-off-by: Jorge Turrado <[email protected]> * Add missing permissions to code-scaners Signed-off-by: Jorge Turrado <[email protected]> * update release tracker Signed-off-by: Jorge Turrado <[email protected]> * fix aws scaler Signed-off-by: Jorge Turrado <[email protected]> * Pass theregion Signed-off-by: Jorge Turrado <[email protected]> * Pass theregion Signed-off-by: Jorge Turrado <[email protected]> * fix aws tests Signed-off-by: Jorge Turrado <[email protected]> * fix aws tests Signed-off-by: Jorge Turrado <[email protected]> * Update AWS admission probes Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * commit last vendored deps Signed-off-by: Jorge Turrado <[email protected]> * fix: Selenium Grid in case multiple scaler triggers are activate (#6437) * fix: Selenium Grid scaler avoids overlapping when multiple browserVersion triggers are active Signed-off-by: Viet Nguyen Duc <[email protected]> * Update CHANGELOG Signed-off-by: Viet Nguyen Duc <[email protected]> * Fix e2e template test Signed-off-by: Viet Nguyen Duc <[email protected]> * Change imagePullPolicy to Always to take latest change Signed-off-by: Viet Nguyen Duc <[email protected]> * Update platformName default value as empty Signed-off-by: Viet Nguyen Duc <[email protected]> --------- Signed-off-by: Viet Nguyen Duc <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * add missing change Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Mårten Svantesson <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Viet Nguyen Duc <[email protected]> Co-authored-by: Omer Aplatony <[email protected]> Co-authored-by: smcavallo <[email protected]> Co-authored-by: Eng Zer Jun <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Viet Nguyen Duc <[email protected]> Co-authored-by: Mårten Svantesson <[email protected]>
Configures automaxprocs to use the application logger instead of default console logging to maintain consistent JSON format across all log output.
output:
keda-operator:
keda-operator-metrics-apiserver:
Checklist
Fixes #5970