-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scaledjobs stuck as not ready #6329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvticket
force-pushed
the
fix_unread_scaledjob
branch
from
November 12, 2024 13:03
fc27e39
to
caf3506
Compare
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
msvticket
force-pushed
the
fix_unread_scaledjob
branch
from
November 12, 2024 15:56
caf3506
to
8cc76e8
Compare
zroubalik
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/run-e2e internal |
JorTurFer
approved these changes
Nov 23, 2024
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]> Signed-off-by: michael pechner <[email protected]>
robpickerill
pushed a commit
to robpickerill/keda
that referenced
this pull request
Nov 30, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Dec 4, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Dec 4, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Dec 4, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
ctccxxd
pushed a commit
to ctccxxd/keda
that referenced
this pull request
Dec 10, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Dec 22, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]>
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Dec 22, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
added a commit
that referenced
this pull request
Dec 24, 2024
* fix: CVE-2024-45337 (#6422) Signed-off-by: Jorge Turrado <[email protected]> * :fix: ensure consistent JSON log format for automaxprocs (#6335) * fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <[email protected]> * moved to Unreleased Signed-off-by: Omer Aplatony <[email protected]> --------- Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Upgrade to the latest new-relic-go v2 client (#6325) Signed-off-by: Jorge Turrado <[email protected]> * refactor: replace experimental `maps` and `slices` with stdlib (#6372) Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA (#6368) Signed-off-by: Jorge Turrado <[email protected]> * fix: scaledjobs stuck as not ready (#6329) since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in #5916 Signed-off-by: Mårten Svantesson <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: Paused ScaledObject count is reported correctly after operator restart (#6322) Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * Bump go and deps (#6434) * Bump go and deps Signed-off-by: Jorge Turrado <[email protected]> * bump golang.org/x/net Signed-off-by: Jorge Turrado <[email protected]> * Add missing permissions to code-scaners Signed-off-by: Jorge Turrado <[email protected]> * update release tracker Signed-off-by: Jorge Turrado <[email protected]> * fix aws scaler Signed-off-by: Jorge Turrado <[email protected]> * Pass theregion Signed-off-by: Jorge Turrado <[email protected]> * Pass theregion Signed-off-by: Jorge Turrado <[email protected]> * fix aws tests Signed-off-by: Jorge Turrado <[email protected]> * fix aws tests Signed-off-by: Jorge Turrado <[email protected]> * Update AWS admission probes Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * commit last vendored deps Signed-off-by: Jorge Turrado <[email protected]> * fix: Selenium Grid in case multiple scaler triggers are activate (#6437) * fix: Selenium Grid scaler avoids overlapping when multiple browserVersion triggers are active Signed-off-by: Viet Nguyen Duc <[email protected]> * Update CHANGELOG Signed-off-by: Viet Nguyen Duc <[email protected]> * Fix e2e template test Signed-off-by: Viet Nguyen Duc <[email protected]> * Change imagePullPolicy to Always to take latest change Signed-off-by: Viet Nguyen Duc <[email protected]> * Update platformName default value as empty Signed-off-by: Viet Nguyen Duc <[email protected]> --------- Signed-off-by: Viet Nguyen Duc <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * add missing change Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Mårten Svantesson <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Viet Nguyen Duc <[email protected]> Co-authored-by: Omer Aplatony <[email protected]> Co-authored-by: smcavallo <[email protected]> Co-authored-by: Eng Zer Jun <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Viet Nguyen Duc <[email protected]> Co-authored-by: Mårten Svantesson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem
Checklist
This is a fix for a regression in #5916