Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable golint: gosimple,whitespace #1218

Merged
merged 1 commit into from
Oct 5, 2020
Merged

enable golint: gosimple,whitespace #1218

merged 1 commit into from
Oct 5, 2020

Conversation

mdeggies
Copy link
Contributor

@mdeggies mdeggies commented Oct 4, 2020 •
edited
Loading

Signed-off-by: Michele [email protected]

Enabled golangci lint: gosimple,whitespace and fixed related issues

Checklist

Fixes # #1158

zroubalik
zroubalik approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 1936bb1 into kedacore:v2 Oct 5, 2020
silenceper pushed a commit to silenceper/keda that referenced this pull request Oct 10, 2020
@mdeggies @silenceper
golint: gosimple,whitespace (kedacore#1218)
25104db 
Signed-off-by: Michele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdeggies @zroubalik