Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linter]enable linters for golangci #1158

Closed
24 of 25 tasks
silenceper opened this issue Sep 15, 2020 · 18 comments · Fixed by #1221, #1267, #1268 or #1393
Closed
24 of 25 tasks

[linter]enable linters for golangci #1158

silenceper opened this issue Sep 15, 2020 · 18 comments · Fixed by #1221, #1267, #1268 or #1393
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers Hacktoberfest stale All issues that are marked as stale due to inactivity

Comments

@silenceper
Copy link
Contributor

silenceper commented Sep 15, 2020 •
edited by zroubalik
Loading

In order to improve code quality, we should enable more linters in the golangci tool:

  • gofmt
  • golint
  • interfacer
  • goimports
  • ineffassign
  • misspell
  • scopelint
  • structcheck
  • bodyclose
  • deadcode
  • depguard
  • dogsled
  • errcheck
  • funlen
  • goconst
  • gocritic
  • gocyclo
  • gosimple
  • staticcheck
  • stylecheck
  • unused
  • varcheck
  • unparam
  • unconvert
  • whitespace

How to enable?
@silenceper silenceper added feature-request All issues for new features that have not been committed to needs-discussion labels Sep 15, 2020
@silenceper silenceper mentioned this issue Sep 15, 2020
Closed
@silenceper
Copy link
Contributor Author

golint,gofmt was add in #1159

@silenceper
Copy link
Contributor Author

/good-first-issue

@ShaileshSurya
Copy link

@silenceper With all the lint's this looks like a big change. How do you expect this to be committed.

One way I see is that breaking this list of lints into smaller lists and creating PR with respect to each of those subgroups. What do you say?

Also the hactoberfest is still days away. When are you expecting this to be committed?

@silenceper
Copy link
Contributor Author

If you add all lints at once, it will be a big change, so my suggestion is to split each lint into a separate pr for submission.

@silenceper
Copy link
Contributor Author

silenceper commented Oct 1, 2020 •
edited
Loading

goimport was add in #1205
misspell, bodyclose was add in #1206

This was referenced Oct 4, 2020
Merged
Merged
Merged
This was referenced Oct 4, 2020
Merged
Merged
@silenceper
Copy link
Contributor Author

/open

@zroubalik zroubalik reopened this Oct 6, 2020
@mdeggies mdeggies mentioned this issue Oct 7, 2020
Merged
3 tasks
agneum added a commit to agneum/keda that referenced this issue Oct 17, 2020
@agneum
enable golangci-lint: interfacer, staticcheck (kedacore#1158)
b049f20
agneum added a commit to agneum/keda that referenced this issue Oct 17, 2020
@agneum
enable golangci-lint: interfacer, staticcheck (kedacore#1158)
95ca3af 
Signed-off-by: Artyom <[email protected]>
@agneum agneum mentioned this issue Oct 17, 2020
Merged
4 tasks
agneum added a commit to agneum/keda that referenced this issue Oct 17, 2020
@agneum
enable golangci-lint: interfacer, staticcheck (kedacore#1158)
a5551a7 
Signed-off-by: akartasov <[email protected]>
agneum added a commit to agneum/keda that referenced this issue Oct 17, 2020
@agneum
enable golangci-lint: scopelint, structcheck (kedacore#1158)
8036cd9 
Signed-off-by: akartasov <[email protected]>
@agneum agneum mentioned this issue Oct 17, 2020
Merged
4 tasks
zroubalik pushed a commit that referenced this issue Oct 19, 2020
@agneum
enable golangci-lint: scopelint, structcheck (#1158) (#1268)
733e92e 
Signed-off-by: akartasov <[email protected]>
@silenceper
Copy link
Contributor Author

@zroubalik please reopen.

@zroubalik zroubalik reopened this Oct 19, 2020
@zroubalik
Copy link
Member

@silenceper thanks, it was automatically closed by the linked PR.

zroubalik pushed a commit that referenced this issue Oct 19, 2020
@agneum
enable golangci-lint: interfacer, staticcheck (#1158) (#1267)
d0788b9 
Signed-off-by: akartasov <[email protected]>
@silenceper
Copy link
Contributor Author

silenceper commented Oct 23, 2020 •
edited
Loading

@zroubalik please reopen ,thanks . 🤣

it was automatically closed again.

@zroubalik zroubalik reopened this Oct 23, 2020
@daxmc99 daxmc99 mentioned this issue Oct 28, 2020
Closed
2 tasks
@girishramnani
Copy link
Contributor

I am currently working on enabling gocyclo

@girishramnani girishramnani mentioned this issue Nov 16, 2020
Merged
2 tasks
@Shubham82 Shubham82 mentioned this issue Nov 18, 2020
Merged
4 tasks
@Shubham82
Copy link
Contributor

I have created a PR for enable goconst in .golangci.yml #1341

@girishramnani
Copy link
Contributor

It seems there is already a PR for goconst #1296

@girishramnani
Copy link
Contributor

@zroubalik if you could please check off the gocyclo box so that it’s not picked up by mistake by someone.

@Shubham82 Shubham82 mentioned this issue Nov 23, 2020
Merged
4 tasks
@Shubham82
Copy link
Contributor

Hi folks,
I have created a PR for enbale depguard and dogsled Linters in .golangcli.yml #1374

@Shubham82
Copy link
Contributor

I am currently working on enabling gocritic

@Shubham82 Shubham82 mentioned this issue Nov 27, 2020
Merged
4 tasks
@Ritikaa96
Copy link
Contributor

Hi, I'm working on enabling errcheck

@Ritikaa96 Ritikaa96 mentioned this issue Dec 3, 2020
Merged
4 tasks
@zroubalik zroubalik reopened this Dec 7, 2020
@zroubalik zroubalik mentioned this issue Jun 7, 2021
Closed
@stale
Copy link

stale bot commented Oct 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
@stale
Copy link

stale bot commented Oct 21, 2021

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 21, 2021
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
@lsolovey
docs: revert deprecation of metricName for Azure Monitor scaler (keda…
e5d61a8 
…core#1158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers Hacktoberfest stale All issues that are marked as stale due to inactivity
Projects
None yet
Milestone
No milestone
6 participants
@zroubalik @silenceper @girishramnani @ShaileshSurya @Shubham82 @Ritikaa96