forked from overhangio/tutor
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add init task to pip-install mounted edx-platform #25
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
be1e169
fix: tutor nightly version suffix
regisb c0d7e26
fix(config): use master branch instead of olive.1
ARMBouhali 5a3b762
fix(patches): remove openedx backport from nightly
ARMBouhali d5f17dd
Merge remote-tracking branch 'origin/master' into nightly
95182ab
Merge remote-tracking branch 'origin/master' into nightly
c866885
Merge remote-tracking branch 'origin/master' into nightly
e987db4
Merge remote-tracking branch 'origin/master' into nightly
9b22498
Merge remote-tracking branch 'origin/master' into nightly
4da32ab
refactor: annotation with __future__.annotations
0f67506
Merge branch 'master' into nightly
regisb cad1e03
Merge remote-tracking branch 'origin/master' into nightly
13d6fc2
Merge remote-tracking branch 'origin/master' into nightly
45addca
Merge remote-tracking branch 'origin/master' into nightly
86bf655
docs: fix typos in hooks changelog entry
kdmccormick 0594677
Merge remote-tracking branch 'origin/master' into nightly
bbab35e
Merge remote-tracking branch 'origin/master' into nightly
928859c
Merge remote-tracking branch 'origin/master' into nightly
d385c44
Merge branch 'master' into nightly
regisb d247c28
Merge remote-tracking branch 'origin/master' into nightly
cbf4caf
Merge remote-tracking branch 'origin/master' into nightly
5f7188a
Merge branch 'master' into nightly
regisb eb4f0e9
Merge remote-tracking branch 'origin/master' into nightly
c669565
Merge remote-tracking branch 'origin/master' into nightly
7076b7c
Merge remote-tracking branch 'origin/master' into nightly
dcec026
feat: add init task to pip-install mounted edx-platform
kdmccormick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<!-- | ||
Create a changelog entry for every new user-facing change. Please respect the following instructions: | ||
- Indicate breaking changes by prepending an explosion 💥 character. | ||
- Prefix your changes with either [Bugfix], [Improvement], [Feature], [Security], [Deprecation]. | ||
- You may optionally append "(by @<author>)" at the end of the line, where "<author>" is either one (just one) | ||
of your GitHub username, real name or affiliated organization. These affiliations will be displayed in | ||
the release notes for every release. | ||
--> | ||
|
||
- [Improvement] Before, Open edX developers needed to pip-install requirements when bind-mounting a local copy of edx-platform the first time. Now, they can just launch the bind-mounted platform instead: ``tutor ... launch --mount=edx-platform`` (by @kdmccormick). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,9 +47,6 @@ RUN git config --global user.email "[email protected]" \ | |
{{ patch("openedx-dockerfile-git-patches-default") }} | ||
{%- else %} | ||
# Patch edx-platform | ||
# Fix broken Circuit Schematic Builder problem template | ||
# https://github.com/openedx/edx-platform/pull/31365 | ||
RUN curl -fsSL https://github.com/openedx/edx-platform/commit/20b93b8b01276edadddfbbb67f15714fddd81c31.patch | git am | ||
{%- endif %} | ||
|
||
{# Example: RUN curl -fsSL https://github.com/openedx/edx-platform/commit/<GITSHA1> | git am #} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
I took this block directly from the other PR: #24
In the context of
do init
, here's no harm in re-runningpip install -e .
, other than the ~2 seconds it take to run, so we could simplify this block to just: