feat: add init task to pip-install mounted edx-platform #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an openedx/edx-platform commit backported as a patch to tutor to olive.1 release Since the commit is already merged into edx-platform:master branch used by tutor nightly, there is no further need for it.
This was referenced Jan 11, 2023
kdmccormick
force-pushed
the
kdmccormick/egg-info-init-task
branch
from
c30b728 to
8b39340
Compare
kdmccormick
force-pushed
the
kdmccormick/egg-info-init-task
branch
from
8b39340 to
b903c69
Compare
kdmccormick
changed the title
kdmccormick
changed the title
kdmccormick
force-pushed
the
kdmccormick/egg-info-init-task
branch
3 times, most recently
from
d68edcf to
a143aa7
Compare
kdmccormick
commented
Jan 11, 2023
Comment on lines
+7
to
+9
| ENTRY_POINTS_INFO=Open_edX.egg-info/entry_points.txt | ||
| if [ ! -f "$ENTRY_POINTS_INFO" ] || [ "$ENTRY_POINTS_INFO" -ot setup.py ]; then | ||
| pip install -e . | ||
| fi |
There was a problem hiding this comment.
Note:
I took this block directly from the other PR: #24
In the context of do init, here's no harm in re-running pip install -e ., other than the ~2 seconds it take to run, so we could simplify this block to just:
Suggested change
| ENTRY_POINTS_INFO=Open_edX.egg-info/entry_points.txt | |
| if [ ! -f "$ENTRY_POINTS_INFO" ] || [ "$ENTRY_POINTS_INFO" -ot setup.py ]; then | |
| pip install -e . | |
| fi | |
| pip install -e . |
kdmccormick
force-pushed
the
kdmccormick/egg-info-init-task
branch
from
a143aa7 to
b1974a3
Compare
Adds `from __future__ import annotations` to the top of every module, right below the module's docstring. Replaces any usages of t.List, t.Dict, t.Set, t.Tuple, and t.Type with their built-in equivalents: list, dict, set, tuple, and type. Ensures that make test still passes under Python 3.7, 3.8 and 3.9.
* Remove redundant changelog line * The change should NOT affect most developers ;)
kdmccormick
force-pushed
the
kdmccormick/egg-info-init-task
branch
from
b1974a3 to
dcec026
Compare
|
Closed in favor of overhangio#813, which includes the code from this PR, and then some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements "Option B" from openedx-unsupported/wg-developer-experience#152, specifically:
You can compare this with Option A here: #24