Skip to content

Commit

Permalink
Merge pull request ManageIQ#71 from kbrock/ruby3
Browse files Browse the repository at this point in the history
  • Loading branch information
jrafanie authored and kbrock committed Apr 29, 2022
2 parents 4fbccac + d26d76d commit 824774a
Show file tree
Hide file tree
Showing 6 changed files with 88 additions and 40 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
ruby-version:
- '2.6'
- '2.7'
- '3.0'
rails-version:
- '6.0'
- '6.1'
Expand Down
78 changes: 78 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
# Change Log
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [1.1.1] - 30-Apr-2022

* Ruby 3.0 support

## [1.1.0] - 09-Feb-2022

* Allow rails 6.1

## [1.0.3] - 12-May-2021

* Allow bulk publish of messages to a topic

## [1.0.2] - 4-Jan-2021

* Rails 6.0 Support

## [1.0.1] - 15-Dec-2020

* Allow all kafka options to be passed
* remove sudo:false from .travis.yml
* Use manageiq-style

## [1.0.0] - 28-Sep-2020

* Switch to use rdkafka client

## [0.1.7] - 14-May-2021

* Loosen ActiveSupport dependency to ~> 5.2

## [0.1.6] - 6-July-2020

* Rescue message body decoding errors. Re-raise errors raised by users code of processing received messages.

## [0.1.5] - 6-Jun-2019

* Allow caller to provide extra headers to the message

## [0.1.4] - 3-Apr-2019

* Add an #ack method to a ReceivedMessage to simplify manual acknowledgements
* Allow caller to provide a session_timeout to kafka consumers, default of 30sec

## [0.1.3] - 25-Feb-2019

## 0.1.2 - 11-Dec-2018

* Allow to set max_bytes to each_batch when subscribe to a Kafka topic.

## 0.1.1 - 20-Nov-2018

* By default upon receiving a message or an event, it is automatically acknowledged. But
the subscriber can decide to turn off the auto ack feature and ack it in the callback block.

## 0.1.0 - 4-Oct-2018

* Initial release

[Unreleased]: https://github.com/ManageIQ/manageiq-messaging/compare/v1.1.0...HEAD
[1.1.1]: https://github.com/ManageIQ/manageiq-messaging/compare/v1.0.3...v1.1.0
[1.1.0]: https://github.com/ManageIQ/manageiq-messaging/compare/v1.0.3...v1.1.0
[1.0.3]: https://github.com/ManageIQ/manageiq-messaging/compare/v1.0.2...v1.0.3
[1.0.2]: https://github.com/ManageIQ/manageiq-messaging/compare/v1.0.1...v1.0.2
[1.0.1]: https://github.com/ManageIQ/manageiq-messaging/compare/v1.0.0...v1.0.1
[1.0.0]: https://github.com/ManageIQ/manageiq-messaging/compare/v0.1.7...v1.0.0
[0.1.7]: https://github.com/ManageIQ/manageiq-messaging/compare/v0.1.6...v0.1.7
[0.1.6]: https://github.com/ManageIQ/manageiq-messaging/compare/v0.1.5...v0.1.6
[0.1.5]: https://github.com/ManageIQ/manageiq-messaging/compare/v0.1.4...v0.1.5
[0.1.4]: https://github.com/ManageIQ/manageiq-messaging/compare/v0.1.3...v0.1.4

36 changes: 0 additions & 36 deletions CHANGES

This file was deleted.

2 changes: 1 addition & 1 deletion lib/manageiq/messaging/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module ManageIQ
module Messaging
VERSION = "1.1.0"
VERSION = "1.1.1"
end
end
7 changes: 6 additions & 1 deletion manageiq-messaging.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,17 @@ Gem::Specification.new do |spec|

spec.summary = 'Client library for ManageIQ components to exchange messages through its internal message bus.'
spec.description = 'Client library for ManageIQ components to exchange messages through its internal message bus.'
spec.homepage = 'http://github.com/ManageIQ/manageiq-messaging'
spec.homepage = 'https://github.com/ManageIQ/manageiq-messaging'
spec.license = 'MIT'

spec.files = `git ls-files -z`.split("\x0").reject do |f|
f.match(%r{^(test|spec|features)/})
end
s.metadata = {
"changelog_uri" => "https://github.com/ManageIQ/manageiq-messaging/blob/master/CHANGELOG.md",
"source_code_uri" => "https://github.com/ManageIQ/manageiq-messaging/",
"bug_tracker_uri" => "https://github.com/ManageIQ/manageiq-messaging/issues",
}
spec.bindir = "exe"
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]
Expand Down
4 changes: 2 additions & 2 deletions spec/manageiq/messaging/kafka/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

describe '#initialize' do
it 'creates a client connects to a single host' do
expect(::Rdkafka::Config).to receive(:new).with(:"bootstrap.servers" => "localhost:1234", :"client.id" => "my-ref", :"sasl.protocol" => "SASL_SSL")
expect(::Rdkafka::Config).to receive(:new).with({:"bootstrap.servers" => "localhost:1234", :"client.id" => "my-ref", :"sasl.protocol" => "SASL_SSL"})

described_class.new(
:protocol => 'Kafka',
Expand All @@ -41,7 +41,7 @@
end

it 'converts username/password to sasl parameters' do
expect(::Rdkafka::Config).to receive(:new).with(:"bootstrap.servers" => "localhost:1234", :"client.id" => "my-ref", :"sasl.username" => "user", :"sasl.password" => "password")
expect(::Rdkafka::Config).to receive(:new).with({:"bootstrap.servers" => "localhost:1234", :"client.id" => "my-ref", :"sasl.username" => "user", :"sasl.password" => "password"})

described_class.new(
:protocol => 'Kafka',
Expand Down

0 comments on commit 824774a

Please sign in to comment.