Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruby 3.0 support #71

Merged
merged 1 commit into from
Apr 8, 2022
Merged

add ruby 3.0 support #71

merged 1 commit into from
Apr 8, 2022

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 7, 2022

made the kwargs fixes.

added ruby 3.0 to the matrix.

Fixes #70

@kbrock kbrock added the ruby3 label Apr 7, 2022
@kbrock kbrock mentioned this pull request Apr 7, 2022
29 tasks
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this code is explicitly passing a merged hash so the test should know to do this explicitly in light of 3.0

@kafka_client = ::Rdkafka::Config.new(rdkafka_connection_opts(options))
end
def rdkafka_connection_opts(options)
hosts = Array(options[:hosts] || options[:host])
hosts.collect! { |host| "#{host}:#{options[:port]}" }
result = {:"bootstrap.servers" => hosts.join(',')}
result[:"client.id"] = options[:client_ref] if options[:client_ref]
result[:"sasl.username"] = options[:username] if options[:username]
result[:"sasl.password"] = options[:password] if options[:password]
result.merge(options.except(:port, :host, :hosts, :encoding, :protocol, :client_ref, :username, :password))

@jrafanie jrafanie merged commit 6484890 into ManageIQ:master Apr 8, 2022
@kbrock kbrock deleted the ruby3 branch April 8, 2022 20:29
kbrock pushed a commit to kbrock/manageiq-messaging that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Ruby 3.0
3 participants