Dra 400 check filter for preservica7 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te filter=preservica to mean preservica 7
… test for preservica 7 oai-pmh harvest
tokee
requested changes
Apr 15, 2024
src/main/java/dk/kb/datahandler/oai/OaiResponseFilterPreserviceSeven.java
Outdated
Show resolved
Hide resolved
src/main/java/dk/kb/datahandler/oai/OaiResponseFilterPreserviceSeven.java
Outdated
Show resolved
Hide resolved
src/test/java/dk/kb/datahandler/oai/OaiHarvestClientIntegrationTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of
OaiResponseFilter. The old implementation didn't really make use of the way we're supporting multiple filters. I've renamed the oldOaiResponseFilterPreservicatoOaiResponseFilterPreservicaFiveand then created a new filter where the logic for Preservica 7 has been moved to.As we are moving towards a preservica 7 world, I've chosen to let the filter in YAML files specified as:
filter: preservicareference the newly addedOaiResponseFilterPreservicaSevenclass and introduced afilter: preservica5for backwards compatibility.While testing this filtering locally on jetty, with a local ds-storage. I've stumpled upon an error when harvesting from preservica. I get an
HTTP 401-error with the comment: WWW-Authenticate header missing for response code 401. However I've managed to create an integration test, that passes this. Could you please update your aegis configuration, start ds-storage and try to run the integrationtest:dk.kb.datahandler.oai.OaiHarvestClientIntegrationTest#testPreservicaSevenAuthand afterwards confirm that a call through the OpenAPI interface returns a 401 error? (Btw, this error also occurs on the main branch, when I'm running locally.)