Fix minimap styling issues and add support for zooming #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad for not verifying eslint before pushing up 😓also pushed up a fix for the Karma bug mentioned in codymikol/karma-webpack#350 Let me know if you don't want to resolve it that way, seems to work fine locally when running tests. |
thijstriemstra
suggested changes
Sep 28, 2018
thijstriemstra
approved these changes
Sep 28, 2018
|
@katspaugh can you take a look as well and approve this PR? |
katspaugh
approved these changes
Oct 1, 2018
thijstriemstra
approved these changes
Oct 1, 2018
|
What is the status on fixing the build issues for this PR? |
|
How do you style the region viwer in the minimap? |
|
@bjvalmasedadev you can style it with CSS via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
Fixes some styling issues with the minimap plugin, the height and widths were not being calculated correctly. Also adds support while zooming in on the waveform to update the minimap.
Ignore the weirdness near the end of the gif with the zoom jumping out, that's just my terribly buggy zoom code (outside of wavesurfer) 😆
Breaking in the external API:
Nothing
Breaking changes in the internal API:
Nothing
Todos/Notes:
Nothing yet, maybe I'll find some more stuff to fix later on :) The library is awesome, really enjoying how easy it is to use overall.
Related Issues and other PRs:
fixes #290