Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoomed region in the minimap plugin #290

Closed
katspaugh opened this issue Nov 17, 2014 · 8 comments · Fixed by #1464
Closed

Zoomed region in the minimap plugin #290

katspaugh opened this issue Nov 17, 2014 · 8 comments · Fixed by #1464

Comments

@katspaugh
Copy link
Owner

No description provided.

@echo66
Copy link

echo66 commented Nov 17, 2014

kats, can you give us an overview on this idea? Thanks!

@katspaugh
Copy link
Owner Author

I'm talking about a region on the minimap canvas, showing the current visible portion of the waveform from the main canvas.

Something like this:
Imgur

@echo66
Copy link

echo66 commented Nov 18, 2014

Seems you can integrate the ideas from peak.js. :)

If you use that kind of scroll, I think that the problems with spectogram visualization and minPxPerSec will end.

@drount
Copy link

drount commented Nov 18, 2014

I did that!

Take a look:

https://github.com/drount/wavesurfer.js/tree/wavescroll

It's the wavescroll plugin.

I'm using a pretty outdated version of the wavesurfer code though.

@echo66
Copy link

echo66 commented Nov 18, 2014

Awesome, drount! Note for developers: copy this function to your wavesurfer.js file. Now, we need to implement the relation between zoom factor and width, I guess.

EDIT: there seems to be a conflict between regions plugin and the "selectionForeground" parameter you used in your fork examples, @drount

@katspaugh
Copy link
Owner Author

Thanks @drount!

I'm not going to replace the default scrollbar with the mini-map plugin just yet. What I'd like to do now is just add an overlay, corresponding to the visible area of the main waveform, to the mini-map.

@drount
Copy link

drount commented Nov 27, 2014

@echo66 Yeah, unfortunately as I said, the plugin is developed in an really old version and I do not have the time to keep on with the main repository changes (that changes a lot!)

Actually I didn't even know that the region code that I wrote was extracted as a plugin :P

@katspaugh katspaugh added this to the 1.1 milestone Feb 25, 2015
@julianpoy
Copy link

julianpoy commented Jun 14, 2016

Any updates on this? I notice showOverview:true, but it doesn't seem to work. It surrounds the entire minimap with a green box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants