add func WithFieldIndexer in app #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. we should not inject field indexer when sharedIndexInformer is already started: k8s.io/[email protected]/tools/cache/shared_informer.go:446 all runnable are started parally, like cache ( informer ) , controller. so, if cache start before controller, it will return error: informer has already started Signed-off-by: jtcheng <[email protected]>
chengjingtao
force-pushed
the
feat/add-func-with-field-indexer
branch
4 times, most recently
from
75d5c9c to
3164336
Compare
…eriod is less than or equal to 0 Signed-off-by: jtcheng <[email protected]>
chengjingtao
force-pushed
the
feat/add-func-with-field-indexer
branch
from
3164336 to
9948bfa
Compare
airycanon
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
we should not inject field indexer when sharedIndexInformer is already started: k8s.io/[email protected]/tools/cache/shared_informer.go:446
all runnable are started parally, like cache ( informer ) , controller. so, if cache start before controller, it will return error: informer has already started
add integration resource sync period config
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
specPR link includedfunctionality, content, code)
Release Notes