Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance get docker auth #479

Merged
merged 2 commits into from
Aug 28, 2023
Merged

feat: enhance get docker auth #479

merged 2 commits into from
Aug 28, 2023

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Aug 26, 2023

allow registry with suffix /

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@l-qing
feat: enhance get docker auth
0071f1b 
allow registry with suffix /
@l-qing l-qing force-pushed the feat/enhance-get-docker-auth branch from 9aaded4 to 0071f1b Compare August 26, 2023 04:02
nanjingfm
nanjingfm previously approved these changes Aug 28, 2023
View reviewed changes
apis/artifacts/v1alpha1/registry_types_test.go Show resolved Hide resolved
@l-qing l-qing merged commit 4a383a4 into main Aug 28, 2023
@l-qing l-qing deleted the feat/enhance-get-docker-auth branch August 28, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjingfm nanjingfm nanjingfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-qing @nanjingfm