fix bugs that user could use invalid token to get user owned resource #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjingtao
force-pushed
the
fix/resource-owned-error
branch
3 times, most recently
from
dab4860 to
2cd8c24
Compare
chengjingtao
commented
Jun 6, 2023
danielfbm
approved these changes
Jun 7, 2023
Signed-off-by: jtcheng <[email protected]>
chengjingtao
force-pushed
the
fix/resource-owned-error
branch
from
2cd8c24 to
6ff08f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix bugs that user could use invalid token (unauthorized) to get user owned resource
If user provide a valid jwt token but unauthorized, the UserOwnedResourcePermissionFilter cannot reject it with 401.
So, change SubjectAccessReview to SelfSubjectAccessReview to deal with unauthorized token.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
specPR link includedfunctionality, content, code)
Release Notes