Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file upload common params #428

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

Jeremy-boo
Copy link
Contributor

@Jeremy-boo Jeremy-boo commented Apr 12, 2023

Changes

add file upload common params in pkg.

spec pr: https://github.com/katanomi/spec/pull/231

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@Jeremy-boo Jeremy-boo force-pushed the feat/upload_artifact_with_ui branch 2 times, most recently from ace7cfe to 090481c Compare April 13, 2023 06:44
@Jeremy-boo Jeremy-boo changed the title feat: add copyImage method. feat: add file upload common params Apr 13, 2023
go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
@Jeremy-boo Jeremy-boo force-pushed the feat/upload_artifact_with_ui branch from 090481c to 13e1fac Compare April 13, 2023 13:29
@Jeremy-boo Jeremy-boo force-pushed the feat/upload_artifact_with_ui branch from 13e1fac to 8213faa Compare April 13, 2023 13:33
apis/artifacts/v1alpha1/upload.go Outdated Show resolved Hide resolved
@Jeremy-boo Jeremy-boo merged commit e2fb201 into main Apr 14, 2023
@Jeremy-boo Jeremy-boo deleted the feat/upload_artifact_with_ui branch April 14, 2023 10:12
Jeremy-boo added a commit that referenced this pull request Apr 17, 2023
* feat: add upload params in artifact pkg.

* fix: optimization description.

---------

Co-authored-by: Jeremy-boo <[email protected]>
Jeremy-boo added a commit that referenced this pull request Apr 17, 2023
* feat: add file upload common params (#428)

* feat: add upload params in artifact pkg.

* fix: optimization description.

---------

Co-authored-by: Jeremy-boo <[email protected]>

* feat: add fileupload ResourceAttribute. (#430)

Co-authored-by: Jeremy-boo <[email protected]>

---------

Co-authored-by: Jeremy-boo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants