Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make name in NamedDeployApplicationResult omitempty #375

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

danielfbm
Copy link
Contributor

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@danielfbm danielfbm force-pushed the fix/named-deploy-application-name-empty branch from ed012e0 to 1d1eac5 Compare February 8, 2023 08:28
@danielfbm danielfbm merged commit 301c38c into main Feb 8, 2023
@danielfbm danielfbm deleted the fix/named-deploy-application-name-empty branch February 8, 2023 08:53
kinsolee pushed a commit that referenced this pull request Feb 9, 2023
* fix: Make name in NamedDeployApplicationResult omitempty

* fix: IsConditionChanged will ignore lastTransitionTime to make it more usable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant