Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helper functions to manager finalizer #372

Merged
merged 4 commits into from
Feb 2, 2023
Merged

feat: add helper functions to manager finalizer #372

merged 4 commits into from
Feb 2, 2023

Conversation

nanjingfm
Copy link
Contributor

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

l-qing
l-qing reviewed Feb 2, 2023
View reviewed changes
apis/selection/v1alpha1/base_filter.go Show resolved Hide resolved
apis/selection/v1alpha1/base_filter.go Outdated Show resolved Hide resolved
finalizer/finalizer.go Outdated Show resolved Hide resolved
@nanjingfm nanjingfm merged commit a693cad into main Feb 2, 2023
@nanjingfm nanjingfm deleted the feat/finalizer branch February 2, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-qing l-qing l-qing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanjingfm @l-qing