Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exitCodeOption returns the exit code #362

Merged
merged 4 commits into from
Jan 18, 2023
Merged

fix: exitCodeOption returns the exit code #362

merged 4 commits into from
Jan 18, 2023

Conversation

kycheng
Copy link
Contributor

@kycheng kycheng commented Jan 18, 2023 •
edited
Loading

Changes

  1. exitCodeOption returns the exit code
  2. Fix when the pass rate divisor is 0, return 0.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@kycheng kycheng changed the title Fix/exit code fix: exitCodeOption returns the exit code Jan 18, 2023
@kycheng kycheng merged commit b2f4d4a into main Jan 18, 2023
@kycheng kycheng deleted the fix/exit-code branch January 18, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaudabot alaudabot alaudabot left review comments

@danielfbm danielfbm danielfbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kycheng @danielfbm @alaudabot