chore: optimize the generate name logic #354

l-qing · 2023-01-10T16:05:36Z

Changes

As the author of this PR, please check off the items in this checklist:

spec PR link included
Follows the commit message standard
Meets the contributing guidelines (including
functionality, content, code)
Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
Release notes block below has been filled in or deleted (only if no user facing changes)

names/name.go

alaudabot · 2023-01-10T16:16:01Z

_{updated at Wed Jan 11 03:30:32 UTC 2023}

Status: OK 🟢

Metric	Change set	Target _(main)	After
🧪 Code coverage	87.50% _{Coverage on 8 new lines}	52.80%	52.80% ↔️ 🟢 _{estimated after merge} _{allowed difference 0}
👥 Duplications	0.00% _{Duplications on 0 new lines}	3.20%	3.20% ↔️ 🟢 _{estimated after merge} _{allowed difference 0}

[354]

chore: optimize the generate name logic

820e36f

l-qing commented Jan 10, 2023

View reviewed changes

names/name.go Show resolved Hide resolved

chore: adjust base on comments

7e1fea1

danielfbm approved these changes Jan 11, 2023

View reviewed changes

l-qing merged commit 009fa53 into main Jan 11, 2023

l-qing deleted the chore/adjust-name-generate branch January 11, 2023 03:23