Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix log nil error when http request failed #314

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

nanjingfm
Copy link
Contributor

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@alaudabot
Copy link
Contributor

alaudabot commented Nov 11, 2022

Quality Gate

updated at Mon Nov 21 02:53:19 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (main) After
🧪 Code coverage 0.00%
Coverage on 2 new lines
53.90% 53.90% ↔️ 🟢
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines
0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0

[314]

@nanjingfm nanjingfm force-pushed the fix/nil-log-message branch 2 times, most recently from d322524 to 6532a99 Compare November 11, 2022 12:32
@nanjingfm nanjingfm merged commit 3b738bb into main Nov 21, 2022
@nanjingfm nanjingfm deleted the fix/nil-log-message branch November 21, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants