Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default timeout for controller-manager #296

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

yuzp1996
Copy link
Contributor

@yuzp1996 yuzp1996 commented Oct 9, 2022

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@alaudabot
Copy link
Contributor

alaudabot commented Oct 9, 2022

Quality Gate

updated at Sun Oct 9 12:43:51 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (release-0.5) After
🧪 Code coverage 75.00%
Coverage on 4 new lines
52.00% 52.00% ↔️ 🟢
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines
0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0

[296]

Previously, value of timeout can not be configured and
is 10s as default value.

Now add the falg kube-api-timeout that can be configured by
falg.

Signed-off-by: yuzhipeng <[email protected]>
@yuzp1996 yuzp1996 force-pushed the hotfix-release-0.5/change-default-time branch from 8a95b17 to 3e779ad Compare October 9, 2022 12:08
@yuzp1996 yuzp1996 changed the base branch from main to release-0.5 October 9, 2022 12:33
@yuzp1996 yuzp1996 merged commit 6956f75 into release-0.5 Oct 10, 2022
@yuzp1996 yuzp1996 deleted the hotfix-release-0.5/change-default-time branch October 10, 2022 03:40
yuzp1996 added a commit that referenced this pull request Oct 10, 2022
Previously, value of timeout can not be configured and
is 10s as default value.

Now add the falg kube-api-timeout that can be configured by
falg.

Signed-off-by: yuzhipeng <[email protected]>

Signed-off-by: yuzhipeng <[email protected]>
yuzp1996 added a commit that referenced this pull request Oct 11, 2022
Previously, value of timeout can not be configured and
is 10s as default value.

Now add the falg kube-api-timeout that can be configured by
falg.

Signed-off-by: yuzhipeng <[email protected]>

Signed-off-by: yuzhipeng <[email protected]>

Signed-off-by: yuzhipeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants