feat: Add IOStreams inside command/io and add command/args package #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfbm
force-pushed
the
feat/add-iostreams-command-args
branch
from
82ca083 to
b04e6e2
Compare
Quality Gateupdated at Mon Aug 22 02:25:42 UTC 2022 Status: OK 🟢
[249] |
alaudabot
reviewed
Aug 22, 2022
danielfbm
force-pushed
the
feat/add-iostreams-command-args
branch
2 times, most recently
from
dd555ed to
690702f
Compare
nanjingfm
reviewed
Aug 22, 2022
nanjingfm
reviewed
Aug 22, 2022
nanjingfm
previously approved these changes
Aug 22, 2022
With IOStreams from k8s.io/cli-runtime creates a better methods of providing data streams to cli while making it easy to create tests inside those packages command/args is a set of methods to read and extract data from cli arguments making it easy to integrate into other clis and into task scripts
danielfbm
force-pushed
the
feat/add-iostreams-command-args
branch
from
690702f to
a121dec
Compare
nanjingfm
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With IOStreams from k8s.io/cli-runtime creates a better methods of
providing data streams to cli while making it easy to create tests
inside those packages
command/args is a set of methods to read and extract data from cli
arguments making it easy to integrate into other clis and into task
scripts
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
specPR link includedfunctionality, content, code)
Release Notes