feat: Add GitRevision with GetValWithKey #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaudabot
reviewed
Aug 17, 2022
danielfbm
force-pushed
the
feat/add-git-revision-struct
branch
from
e568a84 to
150a654
Compare
danielfbm
changed the title
Quality Gateupdated at Thu Aug 18 01:11:48 UTC 2022 Status: OK 🟢
[246] |
danielfbm
force-pushed
the
feat/add-git-revision-struct
branch
from
150a654 to
572c2ba
Compare
l-qing
previously approved these changes
Aug 17, 2022
danielfbm
force-pushed
the
feat/add-git-revision-struct
branch
from
572c2ba to
04c5307
Compare
l-qing
reviewed
Aug 17, 2022
To provide more complete revision details and simplify usage over different scenarios, the GitRevision struct is added into `apis/meta/v1alpha1` and added into BuildRunGitStatus with the GetValWithKey implementation making the values also available for variable substitution scenarios
danielfbm
force-pushed
the
feat/add-git-revision-struct
branch
from
04c5307 to
e8fb123
Compare
l-qing
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
apis/meta/v1alpha1struct to store Git Revision dataSubmitter Checklist
As the author of this PR, please check off the items in this checklist:
specPR link includedfunctionality, content, code)
Release Notes