Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin client params #237

Merged
merged 3 commits into from
Aug 7, 2022
Merged

feat: add plugin client params #237

merged 3 commits into from
Aug 7, 2022

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Aug 6, 2022

Typically, functions that call plugin clients require fixed parameters.
Avoid repeated generation some parameters, save them to a struct.

Changes

  • feat: add plugin client params

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Typically, functions that call plugin clients require fixed parameters.
Avoid repeated generation some parameters, save them to a struct.
logging/filter.go Outdated Show resolved Hide resolved
plugin/client/git_plugin_client_params.go Outdated Show resolved Hide resolved
plugin/client/plugin_client_params.go Outdated Show resolved Hide resolved
plugin/client/plugin_client_params.go Outdated Show resolved Hide resolved
plugin/client/context.go Show resolved Hide resolved
plugin/client/plugin_client.go Show resolved Hide resolved
plugin/client/plugin_client.go Show resolved Hide resolved
plugin/client/plugin_client.go Show resolved Hide resolved
plugin/client/plugin_client.go Show resolved Hide resolved
plugin/client/plugin_client.go Show resolved Hide resolved
plugin/client/plugin_client.go Show resolved Hide resolved
@danielfbm
Copy link
Contributor

plugin client那个改动需要跟 @nanjingfm 沟通一下,昨天他也提到了一些这块的想法

@l-qing l-qing merged commit 09ce559 into main Aug 7, 2022
@l-qing l-qing deleted the feat/add-pluginclient-params branch August 7, 2022 14:37
@airycanon airycanon mentioned this pull request Jan 9, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants