Add SecretType to allow secret selecting with type #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjingtao
previously approved these changes
Apr 24, 2022
We used to only select secret with option ExcludedSecretTypes which can help exclude secret which type in the ExcludedSecretTypes list. Now I add SecretTypes means we only want secret which type in the SecretTypes list. It this option provided we will use it if not provided means there is no limit for secret type when selecting Signed-off-by: yuzhipeng <[email protected]>
yuzp1996
force-pushed
the
fix/include-secret-type
branch
from
5f85178 to
b1bd1a2
Compare
chengjingtao
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to only select secret with option ExcludedSecretTypes which
can help exclude secret which type in the ExcludedSecretTypes list.
Now I add SecretTypes means we only want secret which type in the
SecretTypes list.
It this option provided we will use it if not provided means there
is no limit for secret type when selecting
Signed-off-by: yuzhipeng [email protected]
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
specPR link includedfunctionality, content, code)
Release Notes