Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic auth type #194

Merged
merged 3 commits into from
Apr 18, 2022
Merged

feat: add dynamic auth type #194

merged 3 commits into from
Apr 18, 2022

Conversation

kycheng
Copy link
Contributor

@kycheng kycheng commented Apr 7, 2022

Changes

  • add dynamic define.
  • add ListOption default pager.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@kycheng
Copy link
Contributor Author

kycheng commented Apr 14, 2022

lint 由于github 使用golang1.18 导致

Copy link
Contributor

@danielfbm danielfbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了评论的内容,看一下lint错误一起修复?

apis/meta/v1alpha1/auth_types.go Outdated Show resolved Hide resolved
airycanon
airycanon previously approved these changes Apr 15, 2022
danielfbm
danielfbm previously approved these changes Apr 15, 2022
@kycheng kycheng merged commit 0e21dfe into main Apr 18, 2022
@kycheng kycheng deleted the feat/other-auth branch April 18, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants