-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic auth type #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kycheng
force-pushed
the
feat/other-auth
branch
from
April 11, 2022 07:06
23a9906
to
e2f9557
Compare
kycheng
commented
Apr 14, 2022
lint 由于github 使用golang1.18 导致 |
danielfbm
requested changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
除了评论的内容,看一下lint错误一起修复?
kycheng
force-pushed
the
feat/other-auth
branch
from
April 14, 2022 06:51
e2f9557
to
dd74989
Compare
kycheng
force-pushed
the
feat/other-auth
branch
from
April 14, 2022 07:01
dd74989
to
d68ce2b
Compare
airycanon
previously approved these changes
Apr 15, 2022
danielfbm
reviewed
Apr 15, 2022
kycheng
force-pushed
the
feat/other-auth
branch
from
April 15, 2022 03:57
5a2aff3
to
a7aec94
Compare
danielfbm
previously approved these changes
Apr 15, 2022
danielfbm
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
spec
PR link includedfunctionality, content, code)