Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert gvk to gvr #192

Merged
merged 1 commit into from
Mar 31, 2022
Merged

convert gvk to gvr #192

merged 1 commit into from
Mar 31, 2022

Conversation

NigelZHANG
Copy link
Contributor

Changes

add convert gvk to gvr function which easy to use k8s error function:
k8s api errors

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@NigelZHANG NigelZHANG force-pushed the feat/resource-convert branch from a14adab to 9fce5aa Compare March 31, 2022 04:42
danielfbm
danielfbm reviewed Mar 31, 2022
View reviewed changes
danielfbm
danielfbm requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@danielfbm danielfbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复用 gomega

@NigelZHANG NigelZHANG force-pushed the feat/resource-convert branch from 9fce5aa to 7697520 Compare March 31, 2022 06:49
@NigelZHANG NigelZHANG force-pushed the feat/resource-convert branch from 7697520 to 0086345 Compare March 31, 2022 06:53
@NigelZHANG NigelZHANG merged commit fb53968 into main Mar 31, 2022
@NigelZHANG NigelZHANG deleted the feat/resource-convert branch March 31, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfbm danielfbm danielfbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NigelZHANG @danielfbm