refactor: test management optimization (#268)

Co-authored-by: jzli <[email protected]>

apis/meta/v1alpha1/constant.go

@@ -50,6 +50,8 @@ const (
 	ErrorReason = "Error"
 	// StartedReason resource started to be reconciled
 	StartedReason = "Started"
+	// BlockedReason a testPlan was blocked
+	BlockedReason = "Blocked"
 )
 
 const (

apis/meta/v1alpha1/testcaseexecution_types.go

@@ -17,6 +17,9 @@ limitations under the License.
 package v1alpha1
 
 import (
+	"regexp"
+	"strings"
+
 	authv1 "k8s.io/api/authorization/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -79,3 +82,22 @@ func TestCaseExecutionResourceAttributes(verb string) authv1.ResourceAttributes
 		Verb:     verb,
 	}
 }
+
+func UserSpecFromNote(note string) *UserSpec {
+	if note == "" {
+		return nil
+	}
+
+	reg, _ := regexp.Compile("\\[createdBy: ([\\w@.\\-_]*\\|[\\w@.\\-_]*)]")
+	matches := reg.FindStringSubmatch(note)
+	if len(matches) > 1 {
+		splits := strings.Split(matches[1], "|")
+		if len(splits) == 2 {
+			return &UserSpec{
+				Name:  splits[0],
+				Email: splits[1],
+			}
+		}
+	}
+	return nil
+}

apis/meta/v1alpha1/testcaseexecution_types_test.go

@@ -17,6 +17,9 @@ limitations under the License.
 package v1alpha1
 
 import (
+	"reflect"
+	"testing"
+
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	authv1 "k8s.io/api/authorization/v1"
@@ -34,3 +37,74 @@ var _ = Describe("TestCaseExecution", func() {
 		})
 	})
 })
+
+func Test_executorFromNote(t *testing.T) {
+	tests := []struct {
+		name string
+		note string
+		want *UserSpec
+	}{
+		{
+			name: "empty string",
+			note: "",
+			want: nil,
+		},
+		{
+			name: "invalid string format",
+			note: "xxxxxx",
+			want: nil,
+		},
+		{
+			name: "invalid user string",
+			note: "[createdBy: xxx!!!xxx]",
+			want: nil,
+		},
+		{
+			name: "valid user string",
+			note: "[createdBy: xxx|[email protected]]",
+			want: &UserSpec{
+				Name:  "xxx",
+				Email: "[email protected]",
+			},
+		},
+		{
+			name: "allow email is not valid",
+			note: "[createdBy: xxx|xxxxx]",
+			want: &UserSpec{
+				Name:  "xxx",
+				Email: "xxxxx",
+			},
+		},
+		{
+			name: "allow email is empty",
+			note: "[createdBy: xxx|]",
+			want: &UserSpec{
+				Name:  "xxx",
+				Email: "",
+			},
+		},
+		{
+			name: "allow both is empty",
+			note: "[createdBy: |]",
+			want: &UserSpec{
+				Name:  "",
+				Email: "",
+			},
+		},
+		{
+			name: "allow both is empty",
+			note: "[createdBy: xiangmu@._-|xiangmu@-._]",
+			want: &UserSpec{
+				Name:  "xiangmu@._-",
+				Email: "xiangmu@-._",
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := UserSpecFromNote(tt.note); !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("UserSpecFromNote() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

apis/meta/v1alpha1/testplan_types.go

@@ -22,6 +22,8 @@ import (
 	"knative.dev/pkg/apis"
 )
 
+const DefaultTestPlansPerPage = 20
+
 var TestPlanGVK = GroupVersion.WithKind("TestPlan")
 var TestPlanListGVK = GroupVersion.WithKind("TestPlanList")