fix: zero test result

Allow IsEmpty returns true even if there is no test cases included in a test execution(failed, passed, skipped are all 0), provided that PassedTestsRate is not empty string.
katanomi · Dec 13, 2022 · 23c0fea · 23c0fea
1 parent 9975550
commit 23c0fea
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/apis/codequality/v1alpha1/unit_tests_funcs.go b/apis/codequality/v1alpha1/unit_tests_funcs.go
@@ -65,7 +65,7 @@ func (t *TestResult) IsEmpty() bool {
 	if t == nil {
 		return true
 	}
-	return t.Failed+t.Passed+t.Skipped == 0
+	return t.Failed+t.Passed+t.Skipped == 0 && t.PassedTestsRate == ""
 }
 
 // GetObjectWithValues inits an object based on a json.path values map

diff --git a/apis/codequality/v1alpha1/unit_tests_funcs_test.go b/apis/codequality/v1alpha1/unit_tests_funcs_test.go
@@ -124,6 +124,12 @@ func TestUnitTestsResultIsEmpty(t *testing.T) {
 		g.Expect(object.IsEmpty()).To(gomega.BeFalse())
 	})
 
+	t.Run("has results with zero values", func(t *testing.T) {
+		g := gomega.NewGomegaWithT(t)
+		object := UnitTestsResult{TestResult: &TestResult{PassedTestsRate: "0.00"}}
+		g.Expect(object.IsEmpty()).To(gomega.BeFalse())
+	})
+
 	t.Run("nil results with coverage", func(t *testing.T) {
 		g := gomega.NewGomegaWithT(t)
 		object := UnitTestsResult{Coverage: &TestCoverage{Lines: "1"}}