This repository has been archived by the owner on May 12, 2021. It is now read-only.
Fix ARM CI #1218
Closed
Fix ARM CI #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamwhaley
previously approved these changes
Feb 7, 2019
There was a problem hiding this comment.
lgtm
@sameo I predict the checkcommits will complain about 'lack of commit body text' on your 3rd commit btw.
|
/test |
Thanks for the heads-up. Fixed now. |
added 4 commits
February 7, 2019 12:47
The getCPUDetails() routine can be simplified. Fixes: kata-containers#1217 Signed-off-by: Samuel Ortiz <[email protected]>
This is no longer an internal structure. The architecture agnostic genericTestGetCPUDetails() routine relies on it, and ARM64 is not exporting it. Fixes: kata-containers#1217 Signed-off-by: Samuel Ortiz <[email protected]>
Dataa (double a) is probably a typo. Signed-off-by: Samuel Ortiz <[email protected]>
Fixes: kata-containers#1217 Signed-off-by: Samuel Ortiz <[email protected]>
|
/test |
|
Hi~ @sameo @grahamwhaley thanks for the proposal. I have also pulled similar request #1202 to fix the same problem a few days ago. ptal. ;} |
|
/retest |
|
/retest |
And use the shared flags and definitions. Fixes: kata-containers#1217 Signed-off-by: Samuel Ortiz <[email protected]>
|
/retest |
ARM64 does not need all QEMU generic routines. Fixes: kata-containers#1217 Signed-off-by: Samuel Ortiz <[email protected]>
|
/retest |
|
ARM CI is fixed now with #1202, closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217