Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

ARM CI is broken #1217

Closed
sameo opened this issue Feb 7, 2019 · 0 comments
Closed

ARM CI is broken #1217

sameo opened this issue Feb 7, 2019 · 0 comments
Assignees
@sameo

Comments

@sameo
Copy link

sameo commented Feb 7, 2019

Description of problem

Static checks fail with:

02:29:38 cli/kata-check_arm64.go:129:9:warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
02:29:40 cli/kata-check_test.go:141:113:warning: unused variable or constant undeclared name: TestDataa (varcheck)
02:29:40 virtcontainers/qemu_arm64_test.go:43:23:warning: unused variable or constant undeclared name: virt (varcheck)
02:29:40 virtcontainers/qemu_arm64_test.go:50:11:warning: unused variable or constant undeclared name: defaultMemSlots (varcheck)
02:29:40 virtcontainers/qemu_arm64_test.go:54:40:warning: unused variable or constant too few arguments in call to arm64.memoryTopology (varcheck)
02:29:40 virtcontainers/qemu_arm64_test.go:29:23:warning: unused variable or constant undeclared name: virt (varcheck)
02:29:41 cli/kata-check_test.go:141:113:warning: unused struct field undeclared name: TestDataa (structcheck)
02:29:41 virtcontainers/qemu_arm64_test.go:43:23:warning: unused struct field undeclared name: virt (structcheck)
02:29:41 virtcontainers/qemu_arm64_test.go:50:11:warning: unused struct field undeclared name: defaultMemSlots (structcheck)
02:29:41 virtcontainers/qemu_arm64_test.go:54:40:warning: unused struct field too few arguments in call to arm64.memoryTopology (structcheck)
02:29:41 virtcontainers/qemu_arm64_test.go:29:23:warning: unused struct field undeclared name: virt (structcheck)
02:29:41 cli/kata-check_test.go:141:113:warning: undeclared name: TestDataa (staticcheck)
02:29:42 virtcontainers/qemu_arm64_test.go:43:23:warning: undeclared name: virt (unused)
@sameo sameo self-assigned this Feb 7, 2019
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
cli: Simplify the ARM check
5fca6bb 
The getCPUDetails() routine can be simplified.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
cli: Export the TestDataa structure
c66ccec 
This is no longer an internal structure. The architecture agnostic
genericTestGetCPUDetails() routine relies on it, and ARM64 is not
exporting it.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
virtcontainers: Fix ARM64 QEMU unit tests
67fa45d 
Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
@sameo sameo mentioned this issue Feb 7, 2019
Closed
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
virtcontainers: Fix ARM64 QEMU unit tests
b5c1eda 
Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
cli: Simplify the ARM check
fe78bab 
The getCPUDetails() routine can be simplified.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
cli: Export the TestDataa structure
87698a2 
This is no longer an internal structure. The architecture agnostic
genericTestGetCPUDetails() routine relies on it, and ARM64 is not
exporting it.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
virtcontainers: Fix ARM64 QEMU unit tests
941c840 
Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
cli: Improve the ARM64 checks
a8ecdb4 
And use the shared flags and definitions.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
virtcontainers: Tag unused functions and routines for ARM64
4e08885 
ARM64 does not need all QEMU generic routines.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
cli: Improve the ARM64 checks
949f57b 
And use the shared flags and definitions.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 7, 2019
virtcontainers: Tag unused functions and routines for ARM64
2e7c809 
ARM64 does not need all QEMU generic routines.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 8, 2019
virtcontainers: Tag unused functions and routines for ARM64
a00c510 
ARM64 does not need all QEMU generic routines.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 8, 2019
cli: Improve the ARM64 checks
9a04ccb 
And use the shared flags and definitions.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 8, 2019
virtcontainers: Tag unused functions and routines for ARM64
16fdd3b 
ARM64 does not need all QEMU generic routines.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
sameo pushed a commit to sameo/runtime-1 that referenced this issue Feb 9, 2019
virtcontainers: Tag unused functions and routines for ARM64
4763324 
ARM64 does not need all QEMU generic routines.

Fixes: kata-containers#1217

Signed-off-by: Samuel Ortiz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Aug 6, 2020
@jcvenegas
versions: cloud-hypervisor 0.9.0
f6bd9ec 
Highlights for cloud-hypervisor version 0.9.0 include:
virtiofs updates to new dax implementation based in qemu 5.0
Fixed random issues caused due to seccomp filters

io_uring Based Block Device Support

If the io_uring feature is enabled and the host kernel supports it then io_uring will be used for block devices. This results a very significant performance improvement.
Block and Network Device Statistics

Statistics for activity of the virtio network and block devices is now exposed through a new vm.counters HTTP API entry point. These take the form of simple counters which can be used to observe the activity of the VM.
HTTP API Responses

The HTTP API for adding devices now responds with the name that was assigned to the device as well the PCI BDF.
CPU Topology

A topology parameter has been added to --cpus which allows the configuration of the guest CPU topology allowing the user to specify the numbers of sockets, packages per socket, cores per package and threads per core.
Release Build Optimization

Our release build is now built with LTO (Link Time Optimization) which results in a ~20% reduction in the binary size.
Hypervisor Abstraction

A new abstraction has been introduced, in the form of a hypervisor crate so as to enable the support of additional hypervisors beyond KVM.
Snapshot/Restore Improvements

Multiple improvements have been made to the VM snapshot/restore support that was added in the last release. This includes persisting more vCPU state and in particular preserving the guest paravirtualized clock in order to avoid vCPU hangs inside the guest when running with multiple vCPUs.
Virtio Memory Ballooning Support

A virtio-balloon device has been added, controlled through the resize control, which allows the reclamation of host memory by resizing a memory balloon inside the guest.
Enhancements to ARM64 Support

The ARM64 support introduced in the last release has been further enhanced with support for using PCI for exposing devices into the guest as well as multiple bug fixes. It also now supports using an initramfs when booting.
Intel SGX Support

The guest can now use Intel SGX if the host supports it. Details can be found in the dedicated SGX documentation.
Seccomp Sandbox Improvements

The most frequently used virtio devices are now isolated with their own seccomp filters. It is also now possible to pass --seccomp=log which result in the logging of requests that would have otherwise been denied to further aid development.
Notable Bug Fixes

    Our virtio-vsock implementation has been resynced with the implementation from Firecracker and includes multiple bug fixes.
    CPU hotplug has been fixed so that it is now possible to add, remove, and re-add vCPUs (kata-containers#1338)
    A workaround is now in place for when KVM reports MSRs available MSRs that are in fact unreadable preventing snapshot/restore from working correctly (kata-containers#1543).
    virtio-mmio based devices are now more widely tested (kata-containers#275).
    Multiple issues have been fixed with virtio device configuration (kata-containers#1217)
    Console input was wrongly consumed by both virtio-console and the serial. (kata-containers#1521)

Fixes: kata-containers#2864

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Aug 11, 2020
@jcvenegas
versions: cloud-hypervisor 0.9.0
040bdf6 
Highlights for cloud-hypervisor version 0.9.0 include:
virtiofs updates to new dax implementation based in qemu 5.0
Fixed random issues caused due to seccomp filters

io_uring Based Block Device Support

If the io_uring feature is enabled and the host kernel supports it then io_uring will be used for block devices. This results a very significant performance improvement.
Block and Network Device Statistics

Statistics for activity of the virtio network and block devices is now exposed through a new vm.counters HTTP API entry point. These take the form of simple counters which can be used to observe the activity of the VM.
HTTP API Responses

The HTTP API for adding devices now responds with the name that was assigned to the device as well the PCI BDF.
CPU Topology

A topology parameter has been added to --cpus which allows the configuration of the guest CPU topology allowing the user to specify the numbers of sockets, packages per socket, cores per package and threads per core.
Release Build Optimization

Our release build is now built with LTO (Link Time Optimization) which results in a ~20% reduction in the binary size.
Hypervisor Abstraction

A new abstraction has been introduced, in the form of a hypervisor crate so as to enable the support of additional hypervisors beyond KVM.
Snapshot/Restore Improvements

Multiple improvements have been made to the VM snapshot/restore support that was added in the last release. This includes persisting more vCPU state and in particular preserving the guest paravirtualized clock in order to avoid vCPU hangs inside the guest when running with multiple vCPUs.
Virtio Memory Ballooning Support

A virtio-balloon device has been added, controlled through the resize control, which allows the reclamation of host memory by resizing a memory balloon inside the guest.
Enhancements to ARM64 Support

The ARM64 support introduced in the last release has been further enhanced with support for using PCI for exposing devices into the guest as well as multiple bug fixes. It also now supports using an initramfs when booting.
Intel SGX Support

The guest can now use Intel SGX if the host supports it. Details can be found in the dedicated SGX documentation.
Seccomp Sandbox Improvements

The most frequently used virtio devices are now isolated with their own seccomp filters. It is also now possible to pass --seccomp=log which result in the logging of requests that would have otherwise been denied to further aid development.
Notable Bug Fixes

    Our virtio-vsock implementation has been resynced with the implementation from Firecracker and includes multiple bug fixes.
    CPU hotplug has been fixed so that it is now possible to add, remove, and re-add vCPUs (kata-containers#1338)
    A workaround is now in place for when KVM reports MSRs available MSRs that are in fact unreadable preventing snapshot/restore from working correctly (kata-containers#1543).
    virtio-mmio based devices are now more widely tested (kata-containers#275).
    Multiple issues have been fixed with virtio device configuration (kata-containers#1217)
    Console input was wrongly consumed by both virtio-console and the serial. (kata-containers#1521)

Fixes: kata-containers#2864

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Aug 11, 2020
@jcvenegas
versions: cloud-hypervisor 0.9.0
0dcbbd8 
Highlights for cloud-hypervisor version 0.9.0 include:
virtiofs updates to new dax implementation based in qemu 5.0
Fixed random issues caused due to seccomp filters

io_uring Based Block Device Support

If the io_uring feature is enabled and the host kernel supports it then io_uring will be used for block devices. This results a very significant performance improvement.
Block and Network Device Statistics

Statistics for activity of the virtio network and block devices is now exposed through a new vm.counters HTTP API entry point. These take the form of simple counters which can be used to observe the activity of the VM.
HTTP API Responses

The HTTP API for adding devices now responds with the name that was assigned to the device as well the PCI BDF.
CPU Topology

A topology parameter has been added to --cpus which allows the configuration of the guest CPU topology allowing the user to specify the numbers of sockets, packages per socket, cores per package and threads per core.
Release Build Optimization

Our release build is now built with LTO (Link Time Optimization) which results in a ~20% reduction in the binary size.
Hypervisor Abstraction

A new abstraction has been introduced, in the form of a hypervisor crate so as to enable the support of additional hypervisors beyond KVM.
Snapshot/Restore Improvements

Multiple improvements have been made to the VM snapshot/restore support that was added in the last release. This includes persisting more vCPU state and in particular preserving the guest paravirtualized clock in order to avoid vCPU hangs inside the guest when running with multiple vCPUs.
Virtio Memory Ballooning Support

A virtio-balloon device has been added, controlled through the resize control, which allows the reclamation of host memory by resizing a memory balloon inside the guest.
Enhancements to ARM64 Support

The ARM64 support introduced in the last release has been further enhanced with support for using PCI for exposing devices into the guest as well as multiple bug fixes. It also now supports using an initramfs when booting.
Intel SGX Support

The guest can now use Intel SGX if the host supports it. Details can be found in the dedicated SGX documentation.
Seccomp Sandbox Improvements

The most frequently used virtio devices are now isolated with their own seccomp filters. It is also now possible to pass --seccomp=log which result in the logging of requests that would have otherwise been denied to further aid development.
Notable Bug Fixes

    Our virtio-vsock implementation has been resynced with the implementation from Firecracker and includes multiple bug fixes.
    CPU hotplug has been fixed so that it is now possible to add, remove, and re-add vCPUs (kata-containers#1338)
    A workaround is now in place for when KVM reports MSRs available MSRs that are in fact unreadable preventing snapshot/restore from working correctly (kata-containers#1543).
    virtio-mmio based devices are now more widely tested (kata-containers#275).
    Multiple issues have been fixed with virtio device configuration (kata-containers#1217)
    Console input was wrongly consumed by both virtio-console and the serial. (kata-containers#1521)

Fixes: kata-containers#2864

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sameo sameo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sameo @jodh-intel