Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CI: Enable pullapprove #3

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

jodh-intel
Copy link
Contributor

Require two approvals from documentation team members before a PR
can land.

The configuration file is the same as those used for the other repos,
except for the approval team name.

Fixes #2.

Signed-off-by: James O. D. Hunt [email protected]

@jodh-intel
Copy link
Contributor Author

Ping @grahamwhaley, @kata-containers/documentation.

@jodh-intel jodh-intel force-pushed the enable-pullapprove branch 3 times, most recently from dec073d to 2debb5c Compare December 22, 2017 11:55
@jodh-intel
Copy link
Contributor Author

Pullapprove is unhappy with the .pullapprove.yml, which is odd considering it's valid yaml and it's identical to all the other kata pullapprove configs with the exception of the group name.

I've tried removing and re-adding the pullapprove github link and force pushing but still no joy. The error reported by pullapprove is:

"[]" is an invalid value for groups

@grahamwhaley
Copy link
Contributor

It might have been because the documentation team had no repositories associated with it - I just associated it to the documentation repo - so maybe try a refresh and see if that fixed it?

@jodh-intel
Copy link
Contributor Author

@grahamwhaley - good catch, that must have been it!

Require two approvals from documentation team members before a PR
can land.

The configuration file is the same as those used for the other repos,
except for the approval team name.

Fixes kata-containers#2.

Signed-off-by: James O. D. Hunt <[email protected]>
@jodh-intel
Copy link
Contributor Author

Well, before I approve this myself (which seems to be a requirement given that I created the repo), could someone else ack this? :)

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(if I didn't say that before ;-) )

@grahamwhaley
Copy link
Contributor

but apparently requires (self-)approval by @jodh-intel ? :-)

@jodh-intel jodh-intel merged commit fd16a96 into kata-containers:master Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants