This repository has been archived by the owner on May 12, 2021. It is now read-only.
Enable pullapprove #2
Assignees
Comments
jodh-intel
added a commit
to jodh-intel/documentation
that referenced
this issue
Dec 21, 2017
Require two approvals from documentation team members before a PR can land. The configuration file is the same as those used for the other repos, except for the approval team name. Fixes kata-containers#2. Signed-off-by: James O. D. Hunt <[email protected]>
Merged
jodh-intel
added a commit
to jodh-intel/documentation
that referenced
this issue
Dec 22, 2017
Require two approvals from documentation team members before a PR can land. The configuration file is the same as those used for the other repos, except for the approval team name. Fixes kata-containers#2. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/documentation
that referenced
this issue
Dec 22, 2017
Require two approvals from documentation team members before a PR can land. The configuration file is the same as those used for the other repos, except for the approval team name. Fixes kata-containers#2. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/documentation
that referenced
this issue
Dec 22, 2017
Require two approvals from documentation team members before a PR can land. The configuration file is the same as those used for the other repos, except for the approval team name. Fixes kata-containers#2. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/documentation
that referenced
this issue
Dec 22, 2017
Require two approvals from documentation team members before a PR can land. The configuration file is the same as those used for the other repos, except for the approval team name. Fixes kata-containers#2. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/documentation
that referenced
this issue
Jan 2, 2018
Require two approvals from documentation team members before a PR can land. The configuration file is the same as those used for the other repos, except for the approval team name. Fixes kata-containers#2. Signed-off-by: James O. D. Hunt <[email protected]>
devimc
pushed a commit
to devimc/kata-documentation
that referenced
this issue
Sep 2, 2019
Re-implement image builder script to generate an image with a double MBR + a DAX metadata. The DAX metadata is read by the NVDIMM driver to know the beginning of the data in the pmem device. This new image format is required to enable DAX in the kernels and hypervisors that support NVDIMM, without breaking the compatibility with the kernels and hypervisors that don't support it. Following diagram shows how the resulting image will look like ``` .-----------.----------.---------------.-----------. | 0 - 512 B | 4 - 8 Kb | 2M - 2M+512B | 3M | |-----------+----------+---------------+-----------+ | MBR kata-containers#1 | DAX | MBR kata-containers#2 | Rootfs | '-----------'----------'---------------'-----------+ | | ^ | ^ | '-data-' '--------' | | '--------rootfs-partition---------' ``` MBR: Master boot record. DAX: Metadata required by the NVDIMM driver to enable DAX in the guest [1][2] (struct nd_pfn_sb). Rootfs: partition that contains the root filesystem (/usr, /bin, etc). Kernels and hypervisors that support DAX/NVDIMM read the MBR kata-containers#2, otherwise MBR kata-containers#1 is read. [1] - https://github.com/kata-containers/osbuilder/blob/master/image-builder/\ nsdax.gpl.c [2] - https://github.com/torvalds/linux/blob/master/drivers/nvdimm/pfn.h fixes kata-containers#263 Signed-off-by: Julio Montes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Require 2 acks from the doc team, for parity with the other repos.
The text was updated successfully, but these errors were encountered: