Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .golangci.yml file to include comments check rule #867

Merged
merged 1 commit into from
Oct 27, 2021
+7 −2
Merged

Update .golangci.yml file to include comments check rule #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,8 @@ linters-settings:
issues:
# The list of ids of default excludes to include or disable. By default it's empty.
include:
- EXC0002 # disable excluding of issues about comments from golint
# disable excluding of issues about comments from revive
# see https://golangci-lint.run/usage/configuration/#command-line-options for more info
- EXC0012
- EXC0013
- EXC0014
3 changes: 2 additions & 1 deletion pkg/controllers/binding/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ import (
)

const (
// FullyAppliedSuccessReason defines the name for the FullyAppliedSuccess condition.
FullyAppliedSuccessReason = "FullyAppliedSuccess"

// FullyAppliedSuccessMessage defines the message for the FullyAppliedSuccess condition.
FullyAppliedSuccessMessage = "All works have been successfully applied"
)

Expand Down