Update .golangci.yml file to include comments check rule #867
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/XS
.golangci.yml
Outdated
| @@ -56,4 +56,4 @@ linters-settings: | |||
| issues: | |||
| # The list of ids of default excludes to include or disable. By default it's empty. | |||
| include: | |||
| - EXC0002 # disable excluding of issues about comments from golint | |||
| - EXC0012 # disable excluding of issues about comments from revive | |||
There was a problem hiding this comment.
Are there descriptions about the EXC0012? Share a link?
There was a problem hiding this comment.
I have updated the comments, like EXC0002, the rule is disabled by default.
There was a problem hiding this comment.
How do you think the EXC0013 and EXC0014?
There was a problem hiding this comment.
Looks helpful, we can include them too.
There was a problem hiding this comment.
This can help us check whether our comments format is correct, eg:
pkg/util/helper/binding.go:35:1: exported: comment on exported type ClusterWeightInfoList should be of the form "ClusterWeightInfoList ..." (with optional leading article) (revive)
// ClusterWeightInfoListaa is a slice of ClusterWeightInfo that implements sort.Interface to sort by Value.
^
Signed-off-by: iawia002 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Signed-off-by: iawia002 [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Made a mistake in #806, now the comments check rule works fine.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/assign @RainbowMango