Temporarily remove Grunt's uncaughtException listeners. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added another commit to handle SIGINT / Ctrl-c. Karma listens for SIGINT and takes care of stopping all the browsers. Grunt, however, does not. So after Karma finished, Grunt will just continue running its task queue. Since Grunt does not listen for SIGINT one would expect Ctrl-c to exit the process immediately. The best we can do is to add our own SIGINT listener and exit the process after Karma is finished. |
jpommerening
changed the title
Remove these listeners while Karma is running, so that Karma gets a chance to stop the browsers it started, in case a framework raises an error or the user presses Ctrl-C. fixes karma-runner#93
Karma listens for SIGINT and disconnects all servers if interrupted. As a side-effect, interrupting the current process causes Karma to stop but nothing else. Any pending Grunt tasks will still run. Since Grunt does not listen to SIGINT itself, the expected behaviour is that the process exits with code 130. We simulate this by listening for SIGINT and calling process.exit() when Karma finished.
|
This seems long dead, but we still get problems on our CI machine with browsers hanging around from grunt-karma failures. It would great to see this updated and merged. |
|
@jpommerening could you rebase this onto latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #93, Grunt's
uncaughtExceptionlisteners fire before Karma gets a chance to stop the browsers it started.The only fix that I can think of is removing Grunt's listners for as long as Karma is running. That way, Karma can gracefully handle a framework raising an error or the user pressing Ctrl-c.
I made a small gist to reproduce the problem: https://gist.github.com/jpommerening/10364033
After running
npm install, running Grunt will (probably) produce the following output:To try the same thing with the changes in this PR: