Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Japanese lyric cannot be detected. #271

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

andy840119
Copy link
Member

Implementation remain part of #263 and fix #264

What's change in this pr:

  • change to customze nuget
  • make japanese's detection into test case.

@andy840119 andy840119 added the bug Something isn't working label Nov 29, 2020
@andy840119 andy840119 added this to the 2020.1219 milestone Nov 29, 2020
@andy840119 andy840119 self-assigned this Nov 29, 2020
@andy840119 andy840119 merged commit 4fc1c29 into karaoke-dev:master Nov 29, 2020
@andy840119 andy840119 deleted the fix-language-detection branch November 29, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant