Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto-detect lyric's language. #264

Merged
merged 4 commits into from
Nov 28, 2020

Conversation

andy840119
Copy link
Member

Implementation of #263 .

The final way is use this package called language-detection, it provide a simple way to detect language.
But now it does not fully support Japanese lyric, should fix this dictionary to add all Hiragana and Katakana.

@andy840119 andy840119 added editor Karaoke ruleset's editor area 3rd Third-party support labels Nov 28, 2020
@andy840119 andy840119 added this to the 2020.1128 milestone Nov 28, 2020
@andy840119 andy840119 self-assigned this Nov 28, 2020
@andy840119
Copy link
Member Author

Make a merge and fix that after.
Also maybe should make a way to import customize dictionary.

@andy840119
Copy link
Member Author

andy840119 commented Nov 28, 2020

http://mail-archives.apache.org/mod_mbox/lucene-commits/201811.mbox/%[email protected]%3E
This is dictionary on define is Japanese text and has some error in here(e.g. : does not have )
Need to find is there any newer version.

@andy840119 andy840119 merged commit ee74438 into karaoke-dev:master Nov 28, 2020
@andy840119 andy840119 deleted the 😃/🀄 branch November 28, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd Third-party support editor Karaoke ruleset's editor area size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant