Redesign caret algorithm for the create remove time tag #1984

andy840119 · 2023-05-07T03:14:09Z

Implement the main part of the issue #1973.

What's done in this PR:

Implement the new caret position algorithm.
Adjust the key binding. For now, we have 2 keys for add the start/end time-tag and another 2 is for delete them.
It's time to say goodbye to the old drawable caret and algorithm.

…ric with target char.

andy840119 · 2023-05-07T03:18:07Z

Let this PR merge first.
Then will take times to think about how to adjust the modify mode.

I think there's no need to use this caret anymore?

Implement the caret position algorithm for able to navigate to the ly…

b09483f

…ric with target char.

andy840119 added enhancement New feature or request LyricMaker Implement lyric maker part into karaoke ruleset. labels May 7, 2023

andy840119 added this to the 2023.0520 milestone May 7, 2023

pull-request-size bot added the size/XXL label May 7, 2023

andy840119 force-pushed the redesign-caret-algorithm-for-the-create-remove-time-tag branch from d27d039 to f6e9013 Compare May 7, 2023 03:18

andy840119 added 7 commits May 7, 2023 11:19

Implement the caret for focus on the lyric char.

0f23d00

Replace to the new caret position algorithm.

64511cf

Adjust the key binding.

029459f

Adjust the button in the toolbar.

f0b4548

It's time to say goodbye to the old drawable caret.

53cebc5

It's time to say goodbye to the old caret position algorithm.

778a4e1

I think there's no need to use this caret anymore?

It's time to say goodbye with the old method.

ca287d9

andy840119 force-pushed the redesign-caret-algorithm-for-the-create-remove-time-tag branch from f6e9013 to ca287d9 Compare May 7, 2023 03:19

andy840119 mentioned this pull request May 7, 2023

Re-design the caret algorithm for the create/remove time-tag mode. #1973

Closed

andy840119 merged commit 07fb792 into karaoke-dev:master May 7, 2023

andy840119 deleted the redesign-caret-algorithm-for-the-create-remove-time-tag branch May 7, 2023 03:35

Provide feedback