Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design the caret algorithm for the create/remove time-tag mode. #1973

Closed
andy840119 opened this issue May 2, 2023 · 3 comments
Closed
Labels
enhancement New feature or request LyricMaker Implement lyric maker part into karaoke ruleset.
Milestone

Comments

@andy840119
Copy link
Member

image
In the create time-tag mode, we use the TimeTagIndexCaretPositionAlgorithm to move the cursor.
But it might be slow

image
It might be better if able to focus to the whole character.

image
In here, we should add 4 keys for the create/remove time-tag.

  • Create start time-tag.
  • Create end time-tag.
  • Remove start time-tag
  • Remove end time-tag.
@andy840119
Copy link
Member Author

Also, should think able is there any need to modify the time-tag index?
Guess it only used to adjust the import lyric?

@andy840119
Copy link
Member Author

andy840119 commented May 2, 2023

Not very sure should have click area like how control point editor did?
image

[Update]
This topic has been moved to the #1974.

@andy840119
Copy link
Member Author

Use the new caret has been implemented in the #1984

@andy840119 andy840119 added this to the 2023.0520 milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LyricMaker Implement lyric maker part into karaoke ruleset.
Projects
None yet
Development

No branches or pull requests

1 participant