Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the stage to command pattern #2294

Closed
andy840119 opened this issue Oct 11, 2024 · 2 comments
Closed

Switch the stage to command pattern #2294

andy840119 opened this issue Oct 11, 2024 · 2 comments
Labels
Playfield Change about playfield.
Milestone

Comments

@andy840119
Copy link
Member

andy840119 commented Oct 11, 2024

Currently, each stage has it's own applier, and it can directly change the property from drawable lyric.

The final goal is able to generate the command from each stage type.
And use another general way(e.g. maybe create stage runner?) to run those command.

https://app.affine.pro/workspace/40306a8a-6c73-4c99-a961-4f928980ef42/uso65AOQC3Hhn3Fs7wh8n
Here's the new structure/working flow for the stage.

Image
And this PR is focus on the first migration part.

@andy840119
Copy link
Member Author

Mark as a part of #2090

@andy840119
Copy link
Member Author

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playfield Change about playfield.
Projects
Status: Done
Development

No branches or pull requests

1 participant