New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the stage using commands structure to affect the lyric property. #2244

Closed

andy840119 opened this issue Jun 2, 2024 · 3 comments

Labels

Playfield

Milestone

Member

andy840119 commented Jun 2, 2024

Idea from the https://github.com/ppy/osu/pull/27539/files
It can make adjust lyric effect/position/easing more simple.

andy840119 added the Playfield label

andy840119 added this to the 2024.0606 milestone

Member Author

andy840119 commented Jun 3, 2024

What's should be done:

Remove the StageEffectApplier and PlayfieldStageApplier
Copy and create some customized commands from the Storyboards/Commands
Stage should be able to generate the commands for lyric/playfield.
DrawableLyric/Playfield should be able to execute the commands.

Member Author

andy840119 commented Jun 8, 2024

Maybe wait until storybook editor in the lazer implemented?
Because not very sure IStoryboardCommand or StoryboardCommandGroup will be serializable?

andy840119 removed this from the 2024.0606 milestone

Member Author

andy840119 commented Oct 12, 2024 •

edited

Loading

Mark as similar of #2294

andy840119 added this to the 2024.1010 milestone

andy840119 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment