Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the font config into the shared stage element. #1997

Open
andy840119 opened this issue May 12, 2023 · 3 comments
Open

Move the font config into the shared stage element. #1997

andy840119 opened this issue May 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@andy840119
Copy link
Member

It might be able to have more than one font spacing config for the stage.
So maybe should be better to make it as a part of stage element.

@andy840119 andy840119 added the enhancement New feature or request label May 12, 2023
@andy840119
Copy link
Member Author

andy840119 commented May 12, 2023

最近總覺得腦子不太好使,所以說中文好了

目前我們已經把 skin 和一 些 transformer config(e.g. class stage 和 preview stage 的移動方式) 變成 stage element
之後或許也可以把 font config(e.g. main text spacing) 也變成 stage element
並且能夠被所有 stage 使用

另外這個 class 理論上應該要沒辦法被繼承
或許就叫 "FontStageElement" ?
裏面會定義字型,還有間距

@andy840119
Copy link
Member Author

andy840119 commented May 12, 2023

另外需要想一下
display ruby/romaji 需不需要也移動到這邊?

或許第一階段可以先不用?

如果移動過去的話,需要有一個機制去重新 reload 所有的 lyric stage info.
這個應該不難做到,performance 的問題可以先不做考量

另外把更多的 config 移動到 stage 的好處是在 lyric playfield 中需要的依賴會更少
主軸會變成 stage applier 已經知道所有需要的 resource (e.g. 需要哪一個 texture 或是 shader)
剩下的就是呼叫 resource provider 去取得資源

@andy840119
Copy link
Member Author

Note:
After migrate to the stage command (see #2294), will create a command to change lyric font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant