Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre413 #139

Merged
24 commits merged into from
Oct 30, 2016
Merged

Pre413 #139

24 commits merged into from
Oct 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2016

Follow up commit based on code review, a.k.a. suggestion box (issue #119, ongoing). This pull request contains relevant changes that concludes milestone 4.1.3.

Remaining steps to do from here onwards:

  1. merge this pull request into master (do: test code from branch, review commits, select "squash and merge", revise commit message that contains errata, if any);
  2. update CHANGELOG file for 4.1.3 with reference commit of step 1
  3. create/tag new release (do: elaborate change log into release notes)

P.S.: Selecting "squash and merge" is only useful for commits done by single author.

clearkimura added 24 commits October 20, 2016 13:58
This will automatically provide proper dependencies for Python with version that is defined by hashbang line of all Python scripts (src/*.py, src/*.py.in, src/lib/*.py shall be revised later).
* Update main.py.in

* Update gui.py.in

* Update config.py

* Update message.py

* Update misc.py

* Update chroot.py

* Update clean.py

* Update common.py

* Update deb.py

* Update extract.py

* Update hook.py

* Update pkgm.py

* Update qemu.py

* Update rebuild.py

* Update xnest.py
Fix relative links and paragraph.
Fix relative link for Wiki
Added copyright and link to debian/copyright
Revised text and include main requirements in one line.
@ghost ghost added this to the 4.1.3 milestone Oct 30, 2016
@ghost
Copy link
Author

ghost commented Oct 30, 2016

Now testing installation and usage in Ubuntu Trusty and Debian Jessie.

$ wget https://github.com/clearkimura/Customizer/archive/pre413.tar.gz
...

Updated results

Tested working in Xubuntu Trusty (14.04) 32-bit host system.

  • Package metadata shows correct version '4.1.3' [ OK ]
  • Packaging errors check by lintian are reduced [ OK ]
  • Authentication dialog by pkexec works properly [ OK ]
  • Window icon and Alt-Tab icon shown correctly [ OK ]
  • Safe default for compression is 'gzip' [ OK ]

Most of the features have been tested:

  • Select ISO [ OK ]
  • Install DEB [ OK ] -- using 'hello' binary package downloaded from repository
  • Execute hook [ OK ] -- using simple 'Hello world' program in Python and Bash scripts
  • Terminal [ OK ] -- run 'hello' command provided by installed DEB
  • Rebuild ISO [ OK ]
  • QEMU [ OK ] -- tested without KVM support, since my test machine doesn't have one
  • Clean [ OK ]

Also tested similarly in Debian Jessie Xfce (8.x) 32-bit host system. Except when using Customizer in Debian Jessie, there are few discrepancies (not just 4.1.3, but also earlier releases in general):

  1. Customizer GUI is using fallback theme i.e. Raleigh and built-in Qt dialog instead of GTK+ (This is how Debian handles Qt applications);
  2. Customizer GUI responds relatively poor and slow, then shows unexpected errors that doesn't appear in Ubuntu Trusty (This might be due to Debian Jessie using Systemd init system and services, which seem to handle automated mounting/unmounting file system -- I did read something like this somewhere on the web);
  3. Rebooting host system will resolve the error and regain response (The poor response may be due to my aging machine running single core processor, but then Customizer has been usable and reasonably responsive in Ubuntu for me).

Remarks

I only run Customizer in Debian for testing purpose. I wouldn't recommend using Customizer in Debian mainly because there are some incompatibilites between Ubuntu and Debian. Also, Qt applications behave better in Ubuntu compared to Debian.

All looks good, so proceeding to merge.

@ghost ghost merged commit 228049f into master Oct 30, 2016
@ghost ghost deleted the pre413 branch October 30, 2016 20:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants